Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules to enforce prefixes and suffixes on for generate/loop parameters #1110

Closed
JHertz5 opened this issue Jan 21, 2024 · 3 comments · Fixed by #1111
Closed

Add rules to enforce prefixes and suffixes on for generate/loop parameters #1110

JHertz5 opened this issue Jan 21, 2024 · 3 comments · Fixed by #1111
Assignees

Comments

@JHertz5
Copy link
Contributor

JHertz5 commented Jan 21, 2024

Describe the solution you'd like
I would like to be able to enforce a prefix and/or suffix on parameters for generates and loops, e.g.

for index in t_range loop

becomes

for lv_index in t_range loop
@JHertz5
Copy link
Contributor Author

JHertz5 commented Jan 21, 2024

I am working on a PR for this, it should be raised today.

@JHertz5
Copy link
Contributor Author

JHertz5 commented Jan 21, 2024

I have raised PR #1111 for this issue. Any feedback is very welcome.

@jeremiah-c-leary
Copy link
Owner

Afternoon @JHertz5 ,

I reviewed the PR and it looks good. I was initially thinking there could be a single rule for the generate and loop statements since they both share the parameter_specification production. However, then you would not be able to set generate and loops to different prefixes and suffixes.

Overall the PR looks great.

  1. documentation was created/updated
  2. Tests were added
  3. Rules added
  4. Numbering of the rules are consistent with the current numbering method.

You even fixed some of my copy/paste documentation errors.

Excellent job!!!

I will get this merged to master.

Regards,

--Jeremy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants