Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change KeyboardAvoidingView behavior #12

Closed
Ragularuban opened this issue Dec 23, 2018 · 4 comments
Closed

Ability to change KeyboardAvoidingView behavior #12

Ragularuban opened this issue Dec 23, 2018 · 4 comments
Labels
❔ Question Further information is requested

Comments

@Ragularuban
Copy link
Contributor

I am wondering if there is a possibility to modify the KeyboardAvoidingView behavior of the modal?

@jeremybarbet
Copy link
Owner

I'm re-working this whole part because this is not good at all, what kind of other behavior are you thinking about? It could be a good input for my refactoring on that part.

@jeremybarbet jeremybarbet added the ❔ Question Further information is requested label Dec 23, 2018
@Ragularuban
Copy link
Contributor Author

Hey, I'm just wondering will it be possible to add another scroll view (vertical) inside the modal.

I tried adding them but ended up loosing the swipe to close feature.

@jeremybarbet
Copy link
Owner

Hey!

May I ask you which kind of behavior are you trying to do?

I added two examples on the default modal with a horizontal and a vertical scrollview to show that you need to use the one from react-native-gesture-handler.

Of course the swipe gesture will be lost because it's related to the main modal and not the child scrollview.

Even though, it's still possible to expose the KeyboardAvoidingView props.

@Ragularuban
Copy link
Contributor Author

Basically, I wanted to have height as the behavoir . This is for a purpose of UI change that happens when the keyboard is active.

I have made this change in the current pull request that I submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants