Feat/add qr code support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
jeremyckahn
requested changes
Nov 6, 2022
There was a problem hiding this comment.
Excellent work @krayste ! Thanks for taking the time to implement this. I think it will be very handy for users! I've tested this out and it's working great.
There were just a few minor things I wanted to address. Once we get those sorted out, this should be good to merge!
jeremyckahn
approved these changes
Nov 6, 2022
There was a problem hiding this comment.
Thanks for making all the changes @krayste! This is looking and working great.
I imagine people might make stickers out of Chitchatter QR codes in order to build small ad-hoc communities. This is an excellent addition!
I will merge and release this now. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a QRCode button to the navbar opening a dialog which displays a QRCode using react-qrcode-logo. This QRCode is copy and save-able
