feat(entity/update): remove nested prop in map when set to null #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you refactor this to merge to main? v0.4 was merged in. |
|
@KeKs0r can't you use the |
naorpeled
approved these changes
Nov 7, 2022
naorpeled
reviewed
Nov 7, 2022
naorpeled
changed the title
|
Hey @KeKs0r, |
naorpeled
pushed a commit
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to delete nested values in a map, I ran into issues, that it would crash when providing
nullas value. So I added it to have the same semantics as when providingundefinedThere is a possibility to differentiate between the two. One could Remove the property and the other could set its value to null, but I think its better to handle them the same way: Removing the nested property.