in a finally to close a urllib.urlopen'ed file, check to make sure th…

…e file object is not None.
jeremydhoon · Feb 9, 2011 · 9c9cc13 · 9c9cc13
1 parent 9ebc56d
commit 9c9cc13
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/updatemanager.py b/updatemanager.py
@@ -64,7 +64,8 @@ def github_last_commit(sUser,sRepo,sBranch):
         infile = urllib.urlopen(sUrl)
         dictJson = json.load(infile)
     finally:
-        infile.close()
+        if infile is not None:
+            infile.close()
     listCommit = map(Commit.from_json, dictJson["commits"])
     listCommit.sort(lambda a,b: -cmp(a.dt,b.dt))
     return (listCommit and listCommit[0]) or None