Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc change? #18

Closed
joep opened this issue Nov 27, 2016 · 3 comments
Closed

Doc change? #18

joep opened this issue Nov 27, 2016 · 3 comments

Comments

@joep
Copy link

joep commented Nov 27, 2016

In the section for usage (https://github.com/jeremyevans/forme#usage) the method for creating the form is named 'show_form' but in the discussion that follows it is referred to as 'album_form'. Obviously not a big deal, but a little confusing on my read through.

@jeremyevans
Copy link
Owner

Thanks for letting me know. You are correct, that is a documentation bug, I'll fix it in a couple days.

@joep
Copy link
Author

joep commented Nov 29, 2016

Thanks.

There is also (or at least I think there is after playing around a bit) a problem with the sample wrapper:

Forme.register_transformer(:wrapper, :p){|t| t.tag(:p, {}, t)}

This issue is that if you have a helper or error, e.g.,

f.input :when, :error => 'aaa', :help => 'bbb'

then parameter t is an array of tags and the transformer fails.

@jeremyevans
Copy link
Owner

Thanks for the feedback. I've updated the README to fix the example code for register_transformer, as well as give a better explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants