#Integer ignores options (without raising an error)

[chrisberkhout]

e.g.

Sequel.migration do
  change do
    create_table(:some_table) do
      column :rating, :integer, :unsigned => true, :size => 10 # <- works
      Integer :score, :unsigned => true, :size => 10 # <- is created without options
    end
  end
end

# SQL
CREATE TABLE `some_table` (`rating` integer(10) UNSIGNED, `score` integer)

I had a look, but I can't see any reason why #Integer shouldn't just delegate to #column and work.

I've been using the MySQL adapter.

Any ideas?

[jeremyevans]

:size and :unsigned have never been a recognized options for the Integer generic type. :size only works by accident with column :integer, though for backwards compatibility it will still be recognized. Use column :rating, 'integer(10) unsigned' going forward.

The idea here is that using when generic types (ruby class names), the options recognized are specific to the generic type. Unless it is specifically documented as supported in http://sequel.rubyforge.org/rdoc/files/doc/schema_modification_rdoc.html or in the database adapter RDoc, you should not assume other options will affect the database type used.

With the specific type support (column :integer), there is some generic options handling that is done for all options types, and for backwards compatibility cannot change (as it would break old migrations). I do not encourage relying on this behavior in new code. For database specific types like the ones you are using, I recommend using a string for the type name.

[jeremyevans]

I think there is a bug on that documentation page, as it indicates that :size and :unsigned are universally usable, when that isn't the case. I'll fix that.

[chrisberkhout]

Thanks Jeremy!