Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions take non-const char* #16

Closed
mlepage-google opened this issue Jul 8, 2020 · 4 comments
Closed

Some functions take non-const char* #16

mlepage-google opened this issue Jul 8, 2020 · 4 comments

Comments

@mlepage-google
Copy link

In tft.c, some functions take non-const char* as argument, when they should take const char*.

This makes it fairly annoying to call from C++, where without a const_cast, it will produce compiler warnings.

Some of the functions do take const char*, so they just all need to do so appropriately (which I'm guessing is all of them, as they shouldn't really be altering the input string).

@jeremyjh
Copy link
Owner

jeremyjh commented Aug 6, 2020

Fixed in #21 right?

@jeremyjh jeremyjh closed this as completed Aug 6, 2020
@jeremyjh jeremyjh reopened this Aug 6, 2020
@jeremyjh
Copy link
Owner

jeremyjh commented Aug 6, 2020

Doh sorry, this is talking about function arguments not local declarations.

@mlepage-google
Copy link
Author

Correct. I think I fixed most in #17 but only in tft.c/.h and there are other files. Also it would be good if you could double-check that I didn't miss any, as I was mostly concerned with the ones I was actively using (so I could be sure it still built/worked properly after changing).

@jeremyjh
Copy link
Owner

jeremyjh commented Jun 2, 2021

Closing all open issues as I'm no longer maintaining this library, I've updated the README to reflect it.

@jeremyjh jeremyjh closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants