-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menuconfig fail on idf 4.0 #8
Comments
You are getting an error on a file that is part of IDF, not even getting to the code in this repo. Can you build the samples that come with IDF 4.0.1 ? |
Yes, I checked that first with the hello_world example. Also, I use esp-adf (on top of esp-idf) and the play_mp3 sample worked as well. If you want me to do more testing, I'll do that. I paste the terminal output before the error here for reference:
|
Seems they have or had the problem elsewhere: |
Hello F99, did you manage to compile the code with IDF 4.0.1? I am trying to compile the code but with no sucess, I kwon the have something to do with the CMakelist.txt, bucause there is a project which is based on the same project of this one which compile and the only difference is that all the code is in the main folder, not in the component folder |
@LeandroTE are you also on Windows? I haven't tried to compile on Windows. |
It's probably a bug within esp-idf but requires component.cmake to be invoked, as indicated by the link above. |
@jeremyjh yes I am on windows, and I manage to compile, just I replaced the CMakelist.txt under main folder with the following and compiled fine: set(COMPONENT_SRCDIRS ".") I think Windows have a problem with the path of the varible to send to idf, but with the CMakelist above it works, thank you very much for your support!! |
@LeandroTE I wonder if the problem is this line Can you try building with this in your main\CmakeList.txt? set(SOURCES tft_demo.c)
idf_component_register(
SRCS ${SOURCES}
INCLUDE_DIRS
${CMAKE_CURRENT_LIST_DIR}
$ENV{IDF_PATH}\components
REQUIRES
tft
spiffs
Hard coding the path separator like that can be a compatibility problem for windows. Windows will accept slashes, but I think the IDF_PATH must be using back slashes because we see the combined path like this That might be a problem to have both back and forward slashes? I can't readily test on windows unfortunately. I'm not sure what the best fix would be, we might have to have check if $ENV{IDF_PATH} contains back slashes and then append the path with a backslash instead of slash. |
Came here from the linked ESP-IDF issue. There a couple of things going on here: CMake always uses "CMake paths" internally which use / as the delimiter, there are functions to convert "platform paths" to "CMake Paths". CMake also supports backslash-escaping in strings, which is why it chokes on Windows-style paths sometimes. This means that
... because the build property has already been converted into a CMake path. However, it shouldn't necessary to pass an absolute path to an include directory like this. That itself looks to me like a "quick fix" so that it's possible to have See the linked PR for the fix (it was easier to make it and verify everything builds OK than to guess this was it.) |
In order to make the lib on IDF 4.0.1, I cloned this branch, but got errors:
not sure where to go from here.
Log for reference.
I've recently moved from IDF 3.3 to 4.0.1. On 3.3 I've built the master branch sucessfully with the demo app. I am not too deep into the build mechanics and git yet, accepting recommendations. system: win7
Regards, F99
CMakeOutput.log
The text was updated successfully, but these errors were encountered: