Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow customisation of routes #54

Closed
atymic opened this issue May 28, 2019 · 7 comments
Closed

Feature: Allow customisation of routes #54

atymic opened this issue May 28, 2019 · 7 comments

Comments

@atymic
Copy link
Contributor

atymic commented May 28, 2019

I think this would be a good feature to add.

I think the best way to do this would be similar to how the base laravel auth routes are registered.

You would add LaravelLogger::routes() to your routes file for your app, and this would take an array of config options, such as:

  • route prefix
  • route name prefix
  • middleware
  • routes to disable
    etc

This would be applied to the routes, which would then be added to the app's router routes.
Obviously would have to make it backwards compatible.

The other way would be to allow you to disable the routes with a config option, and then you could add them yourself to your routes file (using the full controller namespace + name)

I'll try and get a PR up when I have a chance :)

This is related to #17

@jeremykenedy
Copy link
Owner

I will keep an eye out for it.

Thanks,

@atymic
Copy link
Contributor Author

atymic commented Jun 13, 2019

FYI PR is up in #55 😄

@matrunchyk
Copy link

matrunchyk commented Jun 17, 2019

Awesome package! Could you please publish this issue and release a new version?

@jeremykenedy
Copy link
Owner

Created release. Thanks for catching that.

@matrunchyk
Copy link

Great, thank you. The only thing - 3 releases before there was v2.4.2 published, and then 1.1.1, and then 1.2.0. Is that intentional?
I have a record in my composer.json where states "jeremykenedy/laravel-logger": "^2.4",, so the newly published versions won't be installed.
Should I change it to "jeremykenedy/laravel-logger": "^1.2", ?

@jeremykenedy
Copy link
Owner

Good catch, that’s just a bonehead error on my part. All fixed :)

@matrunchyk
Copy link

Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants