fix: Prefer pom.properties G/A/V over pom.xml G/A/V to resolve GAV interpolation issues #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aikebah
changed the title
This was
linked to
issues
Feb 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the fix of #5418 to retain the proper pURL when a pom.properties is found.
Fixes Issue #5450
Fixes Issue #5448
Description of Change
When pom.properties is found with at least the properties for G/A/V as documented by maven use the G/A/V coordinates from the pom.properties as those are expected to always contain the fully interpolated values for G/A/V whereas the pom.xml may contain property references that are resolved by Maven in the model-building.
Have test cases been added to cover the new functionality?
no