Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Model to use correlation matrices directly #3

Closed
jeremymanning opened this issue Apr 10, 2018 · 3 comments
Closed

refactor Model to use correlation matrices directly #3

jeremymanning opened this issue Apr 10, 2018 · 3 comments

Comments

@jeremymanning
Copy link
Owner

switch out the numerator/denominator approach with one that uses (z-transformed) correlation matrices directly

  • when new data come in, simply compute the correlation matrix and (if needed) blur it out to the indicated locations
  • update: multiply each object by n_subs, then divided by the sum of n_subs. if locations are different, first blur both matrices out to the union of the locations
  • get_model: compute the inverse of the fisher z-transform (_z2r)
  • sub: for a - b, multiply b's correlation matrix by -1 and run a.update(b)
@jeremymanning jeremymanning added this to the 0.1.2 pull request milestone Apr 10, 2018
@jeremymanning
Copy link
Owner Author

I'm not sure this is needed-- punting for now (removing from milestone)

If the "numerator and denominator" version works with the refactor, i think it's a stronger approach

@jeremymanning jeremymanning removed this from the 0.1.2 pull request milestone Apr 11, 2018
@jeremymanning
Copy link
Owner Author

I've refactored init, but there seems to be a bug whereby the numerator and denominator are getting set to None unexpectedly. I think I could go about this by using different cases to initialize the model:

  • specify model object directly
  • specify numerator and denominator directly
  • specify correlation matrix directly
  • specify brain object
  • specify nifti object
  • specify two model objects with same properties and ensure they're combined correctly
  • specify two model objects with different (overlapping) locations and ensure they're combined correctly
  • specify two model objects with different (non overlapping) locations and ensure they're combined correctly
  • specify a mixed list of the above and ensure everything is combined correctly

@jeremymanning
Copy link
Owner Author

dealt with in supereeg 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant