Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat system not working #5

Closed
marius-m2 opened this issue May 7, 2017 · 3 comments
Closed

Chat system not working #5

marius-m2 opened this issue May 7, 2017 · 3 comments

Comments

@marius-m2
Copy link

Hey,

Been having some issues with chat messages not being sent through by the server.
So this bit
rooms.forEach(function(room){
socket.broadcast.to(room).emit('chat', {id:playerID,txt:txt});
});
doesn't seem to work for me.

Any ideas?

@marius-m2
Copy link
Author

It works fine by replacing the rooms logic with io.emit, but I'm wondering what's running on your example page then, if the source doesn't allow chatting at this moment.

@Jerenaux
Copy link
Owner

Jerenaux commented May 7, 2017

I just pushed a commit to fix it. Several commits ago, I had deleted some code, thinking it wasn't used anymore, but it was actually the code used to manage rooms, which the chat uses. I had forgotten about this and didn't take time to check. Now it should be fixed, it works on my side, if you can confirm to me it works for you I'll close the issue. Thanks for notifying me!

@marius-m2
Copy link
Author

Works great :)
many thanks

@Jerenaux Jerenaux closed this as completed May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants