Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hotkeys in password inputs #3

Closed
wants to merge 1 commit into from

Conversation

nicholasbs
Copy link

A small patch to disable keyboard shortcuts for password fields, unless you've specifically bound to them. Previously only inputs of type text were being ignored.

Great plugin!

Thanks,
-Nick

@theunraveler
Copy link

I think that the hotkey should not fire on ANY input. That way, we don't have to keep updating for each of the different HTML5 fields. Does this pose any problems?

@nicholasbs
Copy link
Author

That doesn't pose any problems for my usecase. I could imagine wanting hotkeys to remain active even if, e.g., a radio button were selected, but I'm not sure if that's a real usecase/anyone actually cares about that.

I'm +0 on disabling hotkeys on all inputs.

@tbranyen
Copy link
Collaborator

This has been updated in the source to only work on password fields you've bound to.

@tbranyen tbranyen closed this May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants