Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p> inside the edit button causes strange rendering #22

Closed
pmario opened this issue Jun 12, 2012 · 4 comments
Closed

<p> inside the edit button causes strange rendering #22

pmario opened this issue Jun 12, 2012 · 4 comments

Comments

@pmario
Copy link
Contributor

pmario commented Jun 12, 2012

FF13 ubuntu 12.04

The "edit" button DOM looks like this:

<button class="btn btn-mini">
  <p>edit</p>
</button>

The assigned CSS for <p> is

p {
    margin: 0 0 9px;
}

The margin-bottom 9px causes the button to look "bloated" in Gecko based brwosers. Is there a paragraph needed inside a button? [1]

[1] http://dev.w3.org/html5/spec/the-button-element.html#the-button-element

@Jermolene
Copy link
Owner

Yes, this is a bug; the intention is that the content of the button would be parsed as a run, and so there wouldn't be a <p> tag. There are actually a number of block vs. run parsing issues that you may run into.

Parenthetically, it's a bit odd that we're seeing different layout in Chrome and Gecko.

@pmario
Copy link
Contributor Author

pmario commented Jun 13, 2012

Since I mainly use FF, I'll stumble upon them :)

@Jermolene
Copy link
Owner

Jolly handy. I tend to do most testing in Chrome, but do flick over to Firefox, Opera and Safari from time to time. I've never tested on IE9/10, which I probably should

@pmario
Copy link
Contributor Author

pmario commented Jun 13, 2012

IE9 had a lot of problems (it crashed) with my pmario space in its early days. It looks better now. But testing with IE I need to reboot the PC and my win7 doesn't have a propper dev setup. .... yes, we probably all should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants