Skip to content

Commit

Permalink
tools: mksunxiboot: Add support for bigger SPL size
Browse files Browse the repository at this point in the history 
Upcoming H616 SoC will need support for bigger SPL size. Increase max.
number to 48 KiB.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
  • Loading branch information
@jernejsk
jernejsk committed Nov 29, 2020
1 parent 889c3a2 commit 3d5c058
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/mksunxiboot.c
View file
Expand Up @@ -45,7 +45,7 @@ int gen_check_sum(struct boot_file_head *head_p)
return 0;
}

#define SUNXI_SRAM_SIZE 0x8000 /* SoC with smaller size are limited before */
#define SUNXI_SRAM_SIZE 0xc000 /* SoC with smaller size are limited before */

This comment has been minimized.

Sign in to view

Copy link
@apritzel

apritzel Dec 2, 2020

Contributor

I guess this is OK for now, ideally we retire this tool anyway. Eventually we want to avoid SPLs for other SoCs growing too big, accidentally. But this tools should be agnostic to the SoC used, so maybe we would always allow 48KB, but warn if it's bigger than 32KB?

This comment has been minimized.

Sign in to view

Copy link
@jernejsk

jernejsk Dec 2, 2020

Author Owner

Yeah, I plan to skip this patch and rebase it on top of your series, which replaces this tool. Note, that this is however correct patch, since this is only max. size (see comment).
#define SRAM_LOAD_MAX_SIZE (SUNXI_SRAM_SIZE - sizeof(struct boot_file_head))

/*
Expand Down

0 comments on commit 3d5c058

Please sign in to comment.