Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare for initial pub release #9

Merged
merged 1 commit into from Oct 23, 2021
Merged

chore: prepare for initial pub release #9

merged 1 commit into from Oct 23, 2021

Conversation

jeroen-meijer
Copy link
Collaborator

Description

This PR prepares for the initial pub release by adding a license and fixing other pana related issues.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jeroen-meijer jeroen-meijer added the chore A chore task. label Oct 23, 2021
@jeroen-meijer jeroen-meijer self-assigned this Oct 23, 2021
GroovinChip
GroovinChip requested changes Oct 23, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just run a melos bootstrap to make sure the lockfile is in sync, just to be sure

@jeroen-meijer
Copy link
Collaborator Author

LGTM but just run a melos bootstrap to make sure the lockfile is in sync, just to be sure

Done! No diff 🎉

@jeroen-meijer jeroen-meijer enabled auto-merge (squash) October 23, 2021 15:47
GroovinChip
GroovinChip approved these changes Oct 23, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeroen-meijer jeroen-meijer merged commit c237c29 into main Oct 23, 2021
@jeroen-meijer jeroen-meijer deleted the chore/prepare-release branch October 23, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroovinChip GroovinChip GroovinChip approved these changes

Assignees

@jeroen-meijer jeroen-meijer

Labels
chore A chore task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeroen-meijer @GroovinChip