Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vctrs::vec_rbind to bind paged results #352

Merged
merged 3 commits into from Mar 17, 2021
Merged

Use vctrs::vec_rbind to bind paged results #352

merged 3 commits into from Mar 17, 2021

Conversation

hongooi73
Copy link
Contributor

@hongooi73 hongooi73 commented Mar 9, 2021 •
edited

Closes #351

@hongooi73
Copy link
Contributor Author

Also added some simple tests; I've renamed test_rbind_pages-names.R to just test_rbind_pages.R.

@jeroen
Copy link
Owner

jeroen commented Mar 9, 2021

Can you also run knitr::knit("vignettes/json-paging.Rmd.orig", "vignettes/json-paging.Rmd") to update the vignette that uses this function?

@hongooi73
Copy link
Contributor Author

Done.

@hongooi73
Copy link
Contributor Author

ping @jeroen Does this look ok? 🙂

@jeroen jeroen merged commit 6a30aca into jeroen:master Mar 17, 2021
@jeroen
Copy link
Owner

jeroen commented Mar 17, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using vctrs::vec_rbind for rbind_pages
2 participants
@hongooi73 @jeroen