Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken backwards compatibility? update appends unknown arrayFilters argument irrespective of mongodb version #116

Closed
rfhb opened this issue Dec 23, 2017 · 3 comments

Comments

@rfhb
Copy link

rfhb commented Dec 23, 2017

Continuous integration of my project with mongodb 3.2 triggers the error:

Unrecognized field in update operation: arrayFilters,

see https://travis-ci.org/rfhb/ctrdata/jobs/320570386#L1772.

I wonder if

BSON_APPEND_ARRAY (&opts, "arrayFilters", filters);

in https://github.com/jeroen/mongolite/blob/master/src/collection.c#L76 should not be appended if the mongodb version is lower than 3.6, considering that such versions are still used. Thank you.

@jeroen
Copy link
Owner

jeroen commented Dec 24, 2017

Ah that is certainly not intended. I have pushed a fix can you try installing the devel version?

devtools::install_github("jeroen/mongolite")

Thanks for reporting.

@rfhb
Copy link
Author

rfhb commented Dec 24, 2017

Great stuff, works for me and closes #118. Many thanks.

@rfhb
Copy link
Author

rfhb commented Dec 26, 2017

Great, thank you, works well for me and addresses my issue. (My feedback here from 24 Dec seems to have gone, apologies.)

@rfhb rfhb closed this as completed Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants