Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with FIPS #96

Open
jeroen opened this issue Mar 1, 2022 · 6 comments
Open

Test with FIPS #96

jeroen opened this issue Mar 1, 2022 · 6 comments

Comments

@jeroen
Copy link
Owner

jeroen commented Mar 1, 2022

On CentOS we can set an envvar OPENSSL_FORCE_FIPS_MODE=1 to enable FIPS.
See #95

@jeroen
Copy link
Owner Author

jeroen commented Mar 1, 2022

Added fips_mode() api: bcdf9dd

@atheriel
Copy link
Contributor

atheriel commented Mar 1, 2022

I have a patch that allows the test suite to run on a FIPS system. Should I submit it to help with this issue?

@jeroen
Copy link
Owner Author

jeroen commented Mar 1, 2022

Sure, I made a start by skipping some tests. But it looks like there are some are actual bugs, where openssl is refusing an operation in places that I did not anticipate. I just saw an error negative length vectors are not allowed which probably means that I am somewhere treating an error code -1 as an actual result and trying to copy that into an R vector.

@atheriel
Copy link
Contributor

atheriel commented Mar 1, 2022

I think I fixed those, let me verify and submit.

@jeroen
Copy link
Owner Author

jeroen commented Mar 1, 2022

Btw, do you have access to the rstudio cloud revdep checker? It would be good if we can identify if the changes broke any R packages.

@atheriel
Copy link
Contributor

atheriel commented Mar 2, 2022

@jeroen I think the answer is "yes". Can you let me know which commit you'd like me to run it against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants