Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to scan custom markers #172

Closed
strappvivek opened this issue Aug 26, 2017 · 16 comments
Closed

Unable to scan custom markers #172

strappvivek opened this issue Aug 26, 2017 · 16 comments

Comments

@strappvivek
Copy link

Hi,
I have tried the steps here: https://aframe.io/blog/arjs/#personalize-your-ar-content to create own markers. I have been able to generate the .patt file and also included the path. But on scan, nothing happens. Anyone facing the same issue and found a solution?

@sloschi
Copy link

sloschi commented Aug 28, 2017

I have a similar problem with the threejs version. See: #164

@wimvdc
Copy link

wimvdc commented Aug 28, 2017

Should be fixed in PR #168

@strappvivek
Copy link
Author

I did try that - but doesnt recognise the custom marker yet.. no error though..

@wimvdc
Copy link

wimvdc commented Aug 29, 2017

Can you provide your .patt file and an image of your marker?

@kumarahir
Copy link

kumarahir commented Aug 29, 2017

Hi @wimvdc please find the code below and attached is patt file with marker. This isn't working for me !

<!-- include A-Frame obviously -->
<script src="https://aframe.io/releases/0.6.0/aframe.min.js"></script>
<!-- include ar.js for A-Frame -->
<script src="https://jeromeetienne.github.io/AR.js/aframe/build/aframe-ar.js"></script>
<body style='margin : 0px; overflow: hidden;'>
  <a-scene embedded arjs>
	<a-marker-camera type='pattern' patternUrl='kum.patt'>
		<a-box position='0 0 0' material='color: red;'></a-box>
	</a-marker-camera>
  </a-scene>
</body>

kum.pdf
kum.zip

@strappvivek
Copy link
Author

@wimvdc
Copy link

wimvdc commented Aug 29, 2017

@strappvivek Doesn't work with my PR either. Your marker seems quite complicated though and when checking the .patt file, I can't seem to find much resemblance to your marker image.
You should try something simpler (something like the Hiro marker)

@strappvivek
Copy link
Author

Let me try it out with a simpler marker...

Is there a limitation with the type of markers that can be used?

thanks

@wimvdc
Copy link

wimvdc commented Aug 30, 2017

The level of detail is definitively limited. When you checkout the Hiro as example (image), you can see that the .patt file (see here) has a structure (at the top) where could read 'Hiro' (you need to look really close).
So I would suggest start from the Hiro image but replace Hiro with a simple word or black/white image.

@sonalranjit
Copy link

The marker generator resizes the image to 16px x 16px so if you want an idea of how the pattern will look like you can see how strong it is by resizing and see if the pattern has strong anchors to be considered a "strong" anchor.
See below example of how the Hiro Pattern is resized:
Original:
inner-hiro

Resized:
screen shot 2017-08-30 at 10 15 31 am

@gitinthehole
Copy link

Curious: Why does the engine use such a seemingly limited pattern? Other engines seem to prefer to have more details in their markers.

@marijae
Copy link

marijae commented Oct 4, 2017

Will it ever be possible to use completely custom markers (photos, shapes) and not being limited with the big black frame, low detail shapes inside and no overlap over the black frame of the marker?

It would be awesome to have more freedom with the marker - to interplay with the actual surfaces. Should I open this as a separate thread?

@javismiles
Copy link

javismiles commented Oct 6, 2017

Hi there, I have the same issues, all works perfect with Hiro marker, but none of my custom markers work, no one of them, it doesn't matter if they have detail, less detail, simple, less simple, etc, etc nothing works except the hiro marker, any tips?

@vin-ni
Copy link

vin-ni commented Oct 20, 2017

I made it work with these instructions:
#164 (comment)

@saurabh183
Copy link

saurabh183 commented Oct 30, 2017

After following steps mentioned in #164, I am still not able to scan custom markers.

Website - https://sadigitaldiaries.com/

I opened above website in mobile and tried to scan below images one by one. Blue box is appearing one marker is hiro. But, it is facing in the case of customer marker (dd).

Markers -
ar

Output -
ar

Kindly assist.

@nicolocarpignoli
Copy link
Collaborator

if still interested, try to use a pixeled text on that 'D D' marker. Use pixeled font.

@saurabh183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests