Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREEx.Sparks doesn't seem to work with three.js r54 #10

Open
chriskilding opened this issue Feb 13, 2013 · 3 comments
Open

THREEx.Sparks doesn't seem to work with three.js r54 #10

chriskilding opened this issue Feb 13, 2013 · 3 comments

Comments

@chriskilding
Copy link

I am trying to use sparks.js in my app via the THREEx.Sparks module you made for this editor.

However it doesn't seem to work with three.js r54 - I guess there have been one too many breaking changes since r46 which this editor uses.

I have put up a (somewhat) minimal example at https://github.com/themasterchef/sparksjs-dev if you want to take a look. The cylinder appears, but the particle system of the sparks is nowhere to be seen (although we can see the scene object has it as a child).

I have updated __dirtyVertices to verticesNeedUpdate already as I am aware that has changed.

Any ideas on how to get it working again (or what I'm doing wrong)?

@v-ulitin
Copy link

Hello, i have too problem, what you did? Thanks.

@chriskilding
Copy link
Author

@kris-v I have submitted a pull request with my fixes at jeromeetienne/threex#33

@v-ulitin
Copy link

@themasterchef Thank you very much;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants