Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS for tab titles (Fixes #130) #132

Closed
wants to merge 9 commits into from
Closed

Added CSS for tab titles (Fixes #130) #132

wants to merge 9 commits into from

Conversation

darkred
Copy link
Contributor

@darkred darkred commented May 28, 2018

Added removed CSS for tab titles (Fixes #130)

Screenshot:
2018-05-28_163547

@jerone
Copy link
Owner

jerone commented May 28, 2018

What about the design already used on that page...
2018-05-28 15_42_41-github

@jerone jerone self-requested a review May 28, 2018 13:45
@darkred
Copy link
Contributor Author

darkred commented May 28, 2018

The thing is, unfortunately I'm not very familiar with CSS, but I'll try to make it the same.

@jerone
Copy link
Owner

jerone commented May 28, 2018

@darkred commented on May 28, 2018, 3:52 PM GMT+2:

The thing is, unfortunately I'm not very familiar with CSS, but I'll try to make it the same.

And what if you use their classes...

@darkred
Copy link
Contributor Author

darkred commented May 28, 2018

And what if you use their classes...

Yes, that's what I did, I copied/based my CSS on the selectors of your screenshot.

I think it's ok now: 🙂
2018-05-28_200041

@darkred
Copy link
Contributor Author

darkred commented May 28, 2018

I updated the new screenshot: the border-bottom-color is actually orange (I had one style enabled by mistake and was turning it blue)

@darkred darkred changed the title 🐛 Added CSS for tab titles (Fixes #130) Added CSS for tab titles (Fixes #130) May 28, 2018
@jerone jerone closed this in e123029 May 28, 2018
@jerone
Copy link
Owner

jerone commented May 28, 2018

Hi @darkred, I went with another solution. I really value your input, it's the only reason I keep this script active 😄

@jerone jerone removed their request for review May 28, 2018 18:18
@darkred darkred deleted the patch-1 branch May 28, 2018 19:37
@darkred
Copy link
Contributor Author

darkred commented May 28, 2018

Thanks a lot for taking the time to fix this properly! I'm glad for all 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants