Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Github Pull Request From Link) Wrong url on forks where another repo name is choosen #145

Closed
eight04 opened this issue Feb 4, 2019 · 2 comments
Closed

(Github Pull Request From Link) Wrong url on forks where another repo name is choosen #145

eight04 opened this issue Feb 4, 2019 · 2 comments
Assignees
@jerone
Labels
bug (Github Pull Request From Link)

Comments

@eight04
Copy link

eight04 commented Feb 4, 2019

Script: Github Pull Request From Link 19.1
Browser: Cent Browser Version 3.8.5.69 (Official Build) (32-bit) (Chromium 71.0.3578.98)
Addon (e.g. Tampermonkey): Tampermonkey BETA 4.8.5898
Description:

STR:

  1. Visit Fix: handle empty at-rules stylus/stylus#2416
  2. Click the eight04:dev-empty-at-rules link
  3. Navigate to https://github.com/eight04/stylus/tree/dev-empty-at-rules and result as 404.

It seems that the repo name in title attribute is correct.
@jerone jerone self-assigned this Feb 4, 2019
@jerone
Copy link
Owner

jerone commented Feb 4, 2019

Thanks for reporting.
I can confirm this being an issue.
It looks like GitHub Refined is doing it correctly.
I'll investigate.

@jerone jerone changed the title (Github Pull Request From Link) Link to a wrong repo (Github Pull Request From Link) Wrong url on forks where another repo name is choosen Feb 4, 2019
@jerone jerone closed this as completed in df9d6ec Feb 4, 2019
@jerone
Copy link
Owner

jerone commented Feb 4, 2019

It looks like you choose another name than the original repo name; stylus-1 instead of stylus: https://github.com/eight04/stylus-1/tree/dev-empty-at-rules.

Anyways, this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerone jerone

Labels
bug (Github Pull Request From Link)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerone @eight04