Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.5 Broken by 2023-11 #168

Closed
mzso opened this issue Nov 5, 2023 · 7 comments
Closed

v1.0.5 Broken by 2023-11 #168

mzso opened this issue Nov 5, 2023 · 7 comments

Comments

@mzso
Copy link

mzso commented Nov 5, 2023

Hi!

This seems to have broken recently. The reply button is unresponsive. And I think it was missing for some issues.

@jerone
Copy link
Owner

jerone commented Nov 5, 2023

Hi @mzso, which script are you talking about?

@mzso
Copy link
Author

mzso commented Nov 5, 2023

Github Reply Comments. There's no insertion of quotes, nor scrolling to the input field.

@mzso
Copy link
Author

mzso commented Nov 23, 2023

@jerone
So, will you take a look at it?

@jerone
Copy link
Owner

jerone commented Nov 23, 2023

@mzso I'm not using it actively. But I'm open for a PR.

@Californ1a
Copy link

Looks like it's just one selector that needs to be changed:

var textareas = newComment.querySelectorAll(":scope > :not(.last-review-thread) .comment-form-textarea:not(.github-writer-ckeditor)");

It seems like .comment-form-textarea doesn't exist on the new comment textarea anymore. No idea about the two other classes referenced in that selector.

@jerone jerone self-assigned this Feb 5, 2024
@jerone jerone closed this as completed in 42608eb Feb 12, 2024
@jerone
Copy link
Owner

jerone commented Feb 13, 2024

@mzso A new version with a fix has been published.

@jerone jerone removed the Needs help label Feb 13, 2024
@mzso
Copy link
Author

mzso commented Feb 13, 2024

@jerone Thanks!
I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants