Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename leftover original name to LlamaIndex #6792

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Rename leftover original name to LlamaIndex #6792

merged 3 commits into from
Jul 9, 2023

Conversation

pycui
Copy link
Contributor

@pycui pycui commented Jul 8, 2023

Description

Rename leftover references to the original project name to LlamaIndex.

Type of Change

  • [ X] This change requires a documentation update

How Has This Been Tested?

  • [X ] I stared at the code and made sure it makes sense

Suggested Checklist:

  • [ X] I have performed a self-review of my own code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ X] New and existing unit tests pass locally with my changes

jerryjliu
jerryjliu approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, approving to unblock

CONTRIBUTING.md Outdated Show resolved Hide resolved
@pycui
Copy link
Contributor Author

pycui commented Jul 9, 2023

@jerryjliu can you help merging this? thanks

@jerryjliu jerryjliu merged commit 6541794 into run-llama:main Jul 9, 2023
8 checks passed
wey-gu pushed a commit to wey-gu/llama_index that referenced this pull request Jul 11, 2023
@pycui @wey-gu
Rename leftover original name to LlamaIndex (run-llama#6792)
b7bba8e 
* Rename left over original name to LlamaIndex

* revert unnecessary change to ipynb

* Address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryjliu jerryjliu jerryjliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pycui @jerryjliu