Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove edit #2

Merged
merged 10 commits into from Feb 18, 2022
Merged

Add remove edit #2

merged 10 commits into from Feb 18, 2022

Conversation

jerryowusu
Copy link
Owner

@jerryowusu jerryowusu commented Feb 17, 2022

Add-Remove-Edit

In this milestone I:

  • Created functions to add and remove task lists from a dynamic array.
  • Implemented a function to edit tasks descriptions.
  • All tasks deleted also updated the remaining item's indexes.
  • All changes on the To-Do lists are also updated on local storage

Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES REQUIRED 🔴 🛑

Hello @jerryowusu, great job you are doing so far in this project. 💯

TO HIGHLIGHT:

  • Your project is professional
  • Your repo is professional
  • Well structured files
  • Great job in adding deleting and editing the task
  • The index is properly assigned

However, there are a few changes to make to move to the next project 🛠️ . Keep working hard 💪 💻

Required Changes ♻️

See my inline comment to know what changes are needed. 👇 👀

Please make these required changes and send it again for another review 👍 💪
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

HAPPY CODING!!! 😄

cat

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/modules/taskClass.js Outdated Show resolved Hide resolved
Copy link

@Rustamxon7 Rustamxon7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jerryowusu 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

Congratulations! 🎉 🎉 🎉 🎉 🎉,

Cheers and Happy coding!👏👏👏

Developer-512px-10


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@jerryowusu jerryowusu merged commit 5de9302 into main Feb 18, 2022
@jerryowusu jerryowusu deleted the Add-Remove-Edit branch February 18, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants