Incorrect mcu script transformation

[galpeter]

By using the tools/generator.sh we transform a js file to a JERRY_MCU_SCRIPT define. However there is a problem, take the following input mcu.js file:

var a = 2 * 2;

Executing the tools/generator.sh mcu.js output command will result the following content in the output file:

#define JERRY_MCU_SCRIPT \
"var a = 2 build CMakeLists.txt jerry-core jerry-libc LICENSE main-linux.cpp main-mcu.cpp main-nuttx.cpp Makefile mcu.js out plugins README.md tests third-party tools 2;\n" \

which clearly can't be used as a start js script.

[galpeter]

For this there is two solutions:

1. enclose the variable used during the transformation:

diff --git a/tools/generator.sh b/tools/generator.sh
index e020fe0..66c0754 100755
--- a/tools/generator.sh
+++ b/tools/generator.sh
@@ -17,7 +17,7 @@
 echo "#define JERRY_MCU_SCRIPT \\" > $2
 cat $1 | while read line
 do
-  line=$(echo $line | sed 's/"/\\"/g')
+  line=$(echo "$line" | sed 's/"/\\"/g')
   echo "\"$line\n\" \\" >> $2
 done
 echo >> $2

2. Rewrite the whole thing with sed:

diff --git a/tools/generator.sh b/tools/generator.sh
index e020fe0..ee0ff47 100755
--- a/tools/generator.sh
+++ b/tools/generator.sh
@@ -15,9 +15,5 @@
 # limitations under the License.

 echo "#define JERRY_MCU_SCRIPT \\" > $2
-cat $1 | while read line
-do
-  line=$(echo $line | sed 's/"/\\"/g')
-  echo "\"$line\n\" \\" >> $2
-done
+sed 's/"/\\"/g' $1 | sed 's/^.*$/"\0" \\/g' >> $2
 echo >> $2

There will be a bit difference in the 2nd case as it will leave any trailing/leading whitespaces intact.

Which solution would be better?

[ruben-ayrapetyan]

@galpeter ,
it seems that leaving whitespaces exactly as they were in source script is better.

[egavrin]

BTW, if someone can propose the better solution than usage of this script, I'd prefer it.

[egavrin]

Fix is merged as #200