Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-Remote-Test Requirement #39

Open
7 tasks
glistening opened this issue Oct 12, 2017 · 7 comments
Open
7 tasks

JS-Remote-Test Requirement #39

glistening opened this issue Oct 12, 2017 · 7 comments

Comments

@glistening
Copy link
Contributor

glistening commented Oct 12, 2017

By @zherczeg's request, I would like to write the requirement for js test framework.

Unifying the test framework

Minimizing the maintenance cost

  • Minimize duplicated code to IoT.js and JerryScript repository

System I/O

  • Cover system I/O also after related sensors are delivered, this item can be started

Etc

  • Remove circular dependencies that exists on current structure
  • We would like to choose IoT.js by commit ID or by indicating path to IoT.js/JerryScript
@glistening
Copy link
Contributor Author

@hs0225 @daeyeon Could you check the requirement ? (missing requirement or invalid requirement, ... )

@zherczeg
Copy link
Member

@rtakacs please explain how #36 will satisfy these requirements

@rtakacs
Copy link
Contributor

rtakacs commented Oct 12, 2017

Status of the main points (with a minimal description):

  • Support IoT.js and JerryScript as main applications.
  • Support multiple targets (device-os pairs).
  • Add js-remote-test to IoT.js as a submodule.
    Not supported yet. First, the circular dependencies should be removed. This can be done by the new architecture (introduced in Change the current architecture #36). What's more, there are other cross dependencies (discussed in #28) that also could be eliminated with the new architecture.
  • System I/O testing.
    Not implemented yet.
  • Minimize duplicated code in IoT.js and JerrScript.
    Since the js-remote-test will be used as a submodule, I think there shouldn't be any duplicated codes.
  • Remove circular dependencies.
    The new architecture could remove circular dependencies.
  • Define commit hash (or tag) for the testrunner.
    I think, the user should change the branch or the commit in iotjs (or jerry) that should be tested.

Bonus:

  • Download dynamically the dependencies.
    Not implemented yet. Currently, there is a init.sh script that downloads all the projects:

    • iotjs
    • jerryscript
    • nuttx
    • nuttx-apps
    • stlink
    • freya
    • tizenrt

    If the user want to test only one target, it's unnecessary to have all the dependencies. This also can be eliminated by using the new builder structure (introduced in Change the current architecture #36). After the target is specified (by a --target option), only the necessary dependencies should be downloaded.

@zherczeg @glistening @hs0225 What do you think? Can I start to modify the architecture in js-remote-test?

@glistening
Copy link
Contributor Author

@rtakacs Yes, please. I've read your new architecture proposal (#36).
@hs0225 Do you have any objection or other idea?

@hs0225
Copy link
Contributor

hs0225 commented Oct 13, 2017

It looks good. In addition, I suggest one more thing.

  • How authorized people publish test results from anywhere.

@rtakacs
Copy link
Contributor

rtakacs commented Oct 16, 2017

@hs0225 There are more tables in the Firebase database for all the targets. If someone wants to maintain a target (run tests on device, and upload that), we can send an email - password pair for him or her. (Please note that the email doesn't need to be valid.) These data should be set by environment variables:

$ export FIREBASE_USER=<e-mail>
$ export FIREBASE_PWD=<password>

After that, the js-remote-test is able to upload the data (--public option is needed).

@glistening
Copy link
Contributor Author

@rtakacs For system I/O tests, there are 2 items:

  1. test automation with system I/O
  2. coverage measuring automation with system I/O

Please contact @hs0225 before beginning system I/O test automation. Hosung may have an idea or design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants