feat: remove lock file & update readme

codes-templates · Aug 4, 2022 · 5b4f262 · 5b4f262
1 parent 3c738f7
commit 5b4f262
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 64,873 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -23,10 +23,7 @@ jobs:
           registry-url: https://registry.npmjs.org/
 
       - name: Install
-        run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+        run: npm i
 
       - name: Lint
         run: npm run lint
@@ -42,7 +39,7 @@ jobs:
           registry-url: https://registry.npmjs.org/
 
       - name: Install
-        run: npm ci
+        run: npm i
 
       - name: Stylelint
         run: npm run stylelint
@@ -58,10 +55,7 @@ jobs:
           registry-url: https://registry.npmjs.org/
 
       - name: Install
-        run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+        run: npm i
 
       - name: Typecheck
         run: npm run typecheck
@@ -77,10 +71,7 @@ jobs:
           registry-url: https://registry.npmjs.org/
 
       - name: Install
-        run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+        run: npm i
 
       - name: Unit Test
         run: npm run test
diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
@@ -19,10 +19,7 @@ jobs:
         with:
           node-version: 16
 
-      - run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+      - run: npm i
 
       - run: npm test
       - run: npm run lint

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -15,10 +15,7 @@ jobs:
         with:
           node-version: 16
 
-      - run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+      - run: npm i
 
       - run: npm test
       - run: npm run lint
@@ -35,10 +32,7 @@ jobs:
           node-version: 16
 
       - name: Install
-        run: npm ci
-
-      - name: Remove react types
-        run: rm -rf node_modules/@types/react
+        run: npm i
 
       - name: Set registry
         run: |

diff --git a/.gitignore b/.gitignore
@@ -9,7 +9,7 @@ node_modules
 .idea/
 *.log
 /coverage
-# package-lock.json
+package-lock.json
 pnpm-lock.yaml
 yarn.lock
 

diff --git a/README.md b/README.md
@@ -47,16 +47,6 @@
 
 replace ```my-custom-vue3-package``` with your package name
 
-**TIPS**:
-*after npm install, run command*
-
-> storybook install react types, but we do not need it
-
-```bash
-rm -rf node_modules/@types/react
-```
-
-
 ## Directory structure
 
 ```js