Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [STYLE] Some card global styles override review history styles #9

Closed
saxoncameron opened this issue Aug 5, 2021 · 8 comments
Closed

Comments

@saxoncameron
Copy link

Hello! I've noticed that the review history element looks strange on one of my note types, which is from Migaku (another third party language-learning community with a growing following). See how it's mainly margins that have been overridden:

Screen Shot 2021-08-05 at 12 55 57 pm

How to fix

I inspected to see which styles specifically, and deduced the following:

Pasted_Image_5_8_21__12_58_pm
Pasted_Image_5_8_21__12_57_pm
Pasted_Image_5_8_21__12_57_pm-2

If you append !important to the above styles as shown (or indeed to ALL your styles if you really want to resist card global styles across the board) then it looks normal.

Thanks!

@jerryzhou196
Copy link
Owner

Oh my god this is so useful holy crap. This pretty much solves 90% of the CSS formatting issues we have been having for the addon where global stylings screw it up! I will implement this ASAP. Once again coming in clutch @saxoncameron - cheers mate!

@FrozenKite
Copy link

I also ran into this issue; for me it was the line spacing that was overridden by the card style.

linespace

To fix this I just added in line-height: normal; to the .tooltiptext CSS rule.

(And you may want to make it line-height: normal !important; based on the above issue)

@jerryzhou196
Copy link
Owner

Thank you so much @FrozenKite for going above and beyond with a solution. I have implemented you and saxon's solution into the code and credited you. Update will be out by today.

@FrozenKite
Copy link

Thanks @jerryzhou196!

(P.S. are you planning to push the recent changes to Github, then people could make pull requests on main 🙃)

@jerryzhou196
Copy link
Owner

Totally. Sorry about not doing that earlier! Will push it right now!

@saxoncameron
Copy link
Author

Can confirm that the latest update fixes the style issues I was having. 👍

@FrozenKite
Copy link

Actually I just tested it and it turns out the outer container also fell victim to my card's line height:

bugthing

The fix is to put line-height: normal !important for the #legend rule as well.

(Sorry, should have noticed it earlier)

@jerryzhou196
Copy link
Owner

For sure and please don't apologize! I really appreciate that you are fixing the add on 😅. (I noticed this with my cloze styling too) Update will be out with the line height on the legend container too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants