Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Issue with PlayerRevive mod #448

Closed
CreativeMD opened this issue Jan 1, 2024 · 3 comments
Closed

[1.20.1] Issue with PlayerRevive mod #448

CreativeMD opened this issue Jan 1, 2024 · 3 comments
Labels
stale This issue has become stale

Comments

@CreativeMD
Copy link

CreativeMD commented Jan 1, 2024

Issue description

Hey,
I'm the creator of PlayerRevive and there seems to be a few issues with your mod.
Video

Seems like the player gets down twice. PlayerRevive works quite simple, it listens to the LivingDeathEvent and cancels it. Once the player has bled out it will trigger the death again. There is a list of damage sources which bypass this system and make the player die instant. Maybe this could solve the issue of the player being downed.

Maybe you got an idea why this is happening? Otherwise would be cool if you can explain how your system works and then we might be able to figure out what is going wrong.

In Regards
CreativeMD

Steps to reproduce

  1. Install PlayerRevive
  2. Die

Minecraft version

1.20.1

Mod Loader Platform type

Forge

Mod Loader version

1.20.1 - 47.2.19

Mod version

v42.0.0

@Jeryn99
Copy link
Owner

Jeryn99 commented Jan 2, 2024

Hello, this class should somewhat walk through everything related to death for forge: https://github.com/Suff99/Regeneration/blob/architectury/1.19.2/forge/src/main/java/mc/craig/software/regen/forge/handlers/CommonEvents.java

I apologize, the codebase has been a bit of a mess due to being ported all the way from 1.12 with different levels of understanding of programming. I plan to redo this mod at some point

@CreativeMD
Copy link
Author

Can you explain in words what your mod does? Because I'm quite confused the player gets downed a second time. Does the player receive any kind of damage when regenerating?

Copy link

This issue has been marked as stale due to inactivity. If this is still a relevant issue, please comment or take action to prevent it from being closed.

@github-actions github-actions bot added the stale This issue has become stale label May 24, 2024
@github-actions github-actions bot closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue has become stale
Projects
None yet
Development

No branches or pull requests

2 participants