Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract and display HTTP warning messages #181

Open
jessecambon opened this issue Dec 3, 2022 · 0 comments
Open

Extract and display HTTP warning messages #181

jessecambon opened this issue Dec 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jessecambon
Copy link
Owner

Currently tidygeocoder only displays warnings/errors in the HTTP response if the HTTP request fails (ie. HTTP code != 200) for single address geocoding:

tidygeocoder/R/geo.R

Line 588 in 2746bfa

if (query_results$status != 200) {

This behavior varies by service for batch geocoding. Ideally we would also display warnings contained in HTTP response even if the HTTP request is successful. One use case here: #178 (comment)
@jessecambon jessecambon added the enhancement New feature or request label Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessecambon