Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for material icons #57

Closed
markcraig opened this issue Aug 10, 2022 · 5 comments
Closed

Support for material icons #57

markcraig opened this issue Aug 10, 2022 · 5 comments

Comments

@markcraig
Copy link

We plan to use Antora Assembler, which relies on asciidoctor-pdf to generate PDFs, which in turn relies on prawn-icon for icon support.

We are increasingly using material icons in our UIs and therefore in our docs.

It would be great if prawn-icon could add support for material icons to make them easy to use when creating PDFs.

@mojavelinux
Copy link

If this proposal is accepted, I suggest using the icon prefix "mi". This follows the naming pattern used for foundation icons.

@jessedoyle
Copy link
Owner

jessedoyle commented Aug 11, 2022

Hey @markcraig! Thanks for using prawn-icon. I would absolutely support a PR that implements material icons into the library.

If this proposal is accepted, I suggest using the icon prefix "mi". This follows the naming pattern used for foundation icons.

Definitely agree!

Looks like Google uses the Apache License which should be fine for distribution in this library - so no concerns there!

I'd be happy to take a stab at this over the next month or two. If anyone wants to submit a PR, the primary AC would be:

  • There needs to be an example in examples directory. Here's the fontawesome example for reference.
  • The rake legend task should execute successfully.
  • The .ttf and supporting legend .yml file is present in data/fonts/mi. Please include a LICENSE file as well.
  • (nice to have) - There's a tool to auto-generate the legend file.

Hope this helps - thanks!

@mojavelinux
Copy link

I appears that this was implemented, merged, and released. Is that correct? If so, I would recommend closing this issue to avoid confusion.

@markcraig
Copy link
Author

Great news! Looking forward to being able to use these in asciidoctor-pdf going forward

@jessedoyle
Copy link
Owner

We did cut release 3.1.0 last week that includes support for Material Design Icons.

It's worthwhile to note that the Material Design Icons collection includes the base icon set from Google as well as a large number of community-maintained icons. The full set can be viewed here.

With that being said, I'm going to close this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants