Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about supporting a local proxy for lazygit? #3185

Closed
moqsien opened this issue Dec 29, 2023 · 2 comments
Closed

How about supporting a local proxy for lazygit? #3185

moqsien opened this issue Dec 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@moqsien
Copy link

moqsien commented Dec 29, 2023

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Set a local proxy for lazygit, and toggle it to be enabled or disabled.

Describe alternatives you've considered

Additional context
Support both http and socks5.

@moqsien moqsien added the enhancement New feature or request label Dec 29, 2023
@stefanhaller
Copy link
Collaborator

I'm not familiar with proxies, but from what I've read, they are configured either through git config (for http) or ~/.ssh/config (for socks). See https://cms-sw.github.io/tutorial-proxy.html for examples.

In general, if something is configurable through git itself, we avoid adding a config in lazygit, for two reasons: to keep lazygit's config space tidy, and so that lazygit behaves as close as possible to git on the command line.

Does that make sense? Do you still think there's a reason to add a config to lazygit itself?

@moqsien
Copy link
Author

moqsien commented Dec 29, 2023

I'm not familiar with proxies, but from what I've read, they are configured either through git config (for http) or ~/.ssh/config (for socks). See https://cms-sw.github.io/tutorial-proxy.html for examples.

In general, if something is configurable through git itself, we avoid adding a config in lazygit, for two reasons: to keep lazygit's config space tidy, and so that lazygit behaves as close as possible to git on the command line.

Does that make sense? Do you still think there's a reason to add a config to lazygit itself?

OK. Get it.
Thanks very much.

@moqsien moqsien closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants