Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits scrollbar cut by icon #3231

Open
Valentin271 opened this issue Jan 18, 2024 · 1 comment
Open

Commits scrollbar cut by icon #3231

Valentin271 opened this issue Jan 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Valentin271
Copy link

Describe the bug

When an icon appears as the last character on the commit tab (probably others too), the scrollbar is cut. See attached screenshots.

To Reproduce
Steps to reproduce the behavior:

  1. Open any git repo with icons (ratatui main has recent commits with icons)
  2. If needed, adjust the size of the terminal/pane so that the icon is the last shown character

Expected behavior
The scrollbar should always be visible. The icon hidden or shown as needed.

Screenshots

lazygit on alacritty
image

lazygit on xfce4-terminal
image

When the handle is aligned with the icon
image

Version info:

$ lazygit --version
commit=5e388e21c8ca6aa883dbcbe45c47f6fdd5116815, build date=2023-08-07T14:05:48Z, build source=binaryRelease, version=0.40.2, os=linux, arch=amd64, git version=2.34.1
$ git --version
git version 2.34.1

Additional context
That's really not disturbing or anything, but still a bug. Your call if you think it's a necessary fix.
It's very likely this is due to icons being multibytes.

Otherwise Lazygit is great, thank you!

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.
I'd like to avoid building from main as I don't have the go tooling installed. But if that's really necessary just tell me.

@Valentin271 Valentin271 added the bug Something isn't working label Jan 18, 2024
@joshka
Copy link

joshka commented Jan 26, 2024

@Valentin271 This one is surprisingly difficult to get right, and likely needs to land on the tui lib in use not the app itself.
Our oldest open issue in Ratatui is about this problem:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants