New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Select a range of files to edit #3404
Comments
On master we have range selection of list items already, no need to invent that. You can select ranges using Right now, editing files is only supported for a single-item selection though, like many other commands that we didn't get around to adapting for ranges yet. This is the only thing left to do, and it doesn't seem terribly hard. Two problems I see with this:
|
Unless we added yet another option for opening in terminal because |
Cool, I didn't know that. For the first point, filtering out sounds nice, as in as you're selecting, a
Sorry I'm not familiar with this |
I wasn't thinking about changing the selection behavior, it should still select items one by one as it does now. What I was thinking of is to have the
And then hope that the editor does something sensible with them? Fine with me. I guess if you are using an editor that can't cope with multiple files (not sure there are any), it's a matter of "just don't do this", then. |
Oh sorry, I did not even think that some might not support that. I know that Neovim and VSCode do, just testing now and even Nano does. I could check some others out if you want?
That sounds OK too. As a side note, I was going to suggest that instead of throwing an error when |
I think it's fine. An editor that doesn't support it will probably either only open the first file, or return an error. Both is fine, users will learn not to do this (or switch to a better editor).
That, plus I think we should focus on things that are really desirable (versus things that we could also do while we're at it, but nobody really needs them). |
Here's the PR: #3407 😄 @Rolv-Apneseth If you know how to build from source, it would be great if you could test it. And if you speak go, maybe even review it. |
I'll figure it out yeah. Unfortunately I do not speak Go, one of these days I'll have to pick it up. |
Fixed by #3407. |
Is your feature request related to a problem? Please describe.
Sometimes when I open
lazygit
, I see a couple of files with changes, and I want to have a closer look at or tweak more than one of them.Describe the solution you'd like
I would like to be able to select a range of files, and open them all together with the editor. I imagine something like
v
, hover over range, thene
, like I would do in, for example, a terminal file manager. Any way you deem best to achieve this would be great though.Describe alternatives you've considered
Currently, this is only possible by editing one, closing the editor and going back to
lazygit
, then continuing to open the others one at a time.The text was updated successfully, but these errors were encountered: