Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect XDG_CONFIG_HOME on MacOS #641

Closed
cideM opened this issue Feb 13, 2020 · 2 comments
Closed

Respect XDG_CONFIG_HOME on MacOS #641

cideM opened this issue Feb 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@cideM
Copy link

cideM commented Feb 13, 2020

Is your feature request related to a problem? Please describe.
This is about the only CLI utility I use which doesn't respect XDG_CONFIG_HOME on MacOS.

Describe the solution you'd like
According to the PR which added config location #150 it uses https://github.com/shibukawa/configdir which simply doesn't take that variable into account.

@cideM cideM added the enhancement New feature or request label Feb 13, 2020
@mjarkk
Copy link
Contributor

mjarkk commented Feb 13, 2020

But isn't XDG_CONFIG_HOME is Linux thing?
Ya sure you can add those shell variables to MacOS but that doesn't mean we will support them, if that would be so we would also need to support XDG_CONFIG_HOME on Windows.

I also think that this issue has more to do with shibukawa/configdir than with lazygit.
If you really think this is something important to have on MacOS i would recommend to pass trough the issue to their repo because in that case other programs can also make use of this.

@cideM
Copy link
Author

cideM commented Feb 14, 2020

Hm good point I'll create the issue in the other repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants