Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto fill by browsers does not trigger re-render #11

Closed
Alexia opened this issue Jun 4, 2014 · 4 comments
Closed

Auto fill by browsers does not trigger re-render #11

Alexia opened this issue Jun 4, 2014 · 4 comments
Labels

Comments

@Alexia
Copy link

Alexia commented Jun 4, 2014

Using the arrow keys to select an existing entry in the form history then pressing tab to select it and continue to the next input field does not update the visual display.

Firefox 29 on OS 10.9

@jessepollak jessepollak changed the title Tab selecting existing form history does not trigger an update to the visual display. Auto fill by browsers does not trigger re-render Jun 5, 2014
@jessepollak jessepollak added the bug label Jun 5, 2014
@jessepollak
Copy link
Owner

When browsers auto fill either through tab complete with arrows (as mentioned above) or through a full form completion, the card does not re-render. I believe this is because we only rerender on keyup, which doesn't get triggered by the autofill. Investigating!

@Alexia
Copy link
Author

Alexia commented Jun 5, 2014

Why not use .change() on the form field?

@jessepollak
Copy link
Owner

The change event only gets fired when you leave the input (so it can't fully replace the keyup event Card was using). I've added it as another event in 6de5a54 and this seems to be resolved.

Would you give it a go?

@jessepollak
Copy link
Owner

This seems fixed. Please reopen if it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants