-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All CSS rules should be scoped #70
Comments
Hm, I'm not sure I want to scope them entirely (I'd like to logos and cards to be reusable components that can be used outside the JS). That said, I can definitely make the CSS classes a little more targeted; perhaps |
I agree, I'd like to be able to use them outside as well. So yeah, something more specific like that would be cool with me. |
👍 prefixed classes |
Just made a PR for this: #79 |
Closing this issue since PR was merged |
In particular, the .logo class here: https://github.com/jessepollak/card/blob/master/src/scss/logos/_logo.scss#L4
This logo class is affecting the actual logo on our site because it's not scoped to the credit card
The text was updated successfully, but these errors were encountered: