Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All CSS rules should be scoped #70

Closed
allenan opened this issue Jun 19, 2014 · 5 comments
Closed

All CSS rules should be scoped #70

allenan opened this issue Jun 19, 2014 · 5 comments
Labels

Comments

@allenan
Copy link

allenan commented Jun 19, 2014

In particular, the .logo class here: https://github.com/jessepollak/card/blob/master/src/scss/logos/_logo.scss#L4

This logo class is affecting the actual logo on our site because it's not scoped to the credit card

@jessepollak
Copy link
Owner

Hm, I'm not sure I want to scope them entirely (I'd like to logos and cards to be reusable components that can be used outside the JS). That said, I can definitely make the CSS classes a little more targeted; perhaps card-logo. What do you think about that?

@allenan
Copy link
Author

allenan commented Jun 19, 2014

I agree, I'd like to be able to use them outside as well. So yeah, something more specific like that would be cool with me.

@luanmuniz
Copy link
Contributor

👍 prefixed classes

@allenan
Copy link
Author

allenan commented Jun 25, 2014

Just made a PR for this: #79

@allenan
Copy link
Author

allenan commented Jun 25, 2014

Closing this issue since PR was merged

@allenan allenan closed this as completed Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants