Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrictNumeric blocks pasting with Ctrl+V #79

Closed
Changaco opened this issue Aug 22, 2017 · 5 comments
Closed

restrictNumeric blocks pasting with Ctrl+V #79

Changaco opened this issue Aug 22, 2017 · 5 comments
Milestone

Comments

@Changaco
Copy link

restrictNumeric() correctly checks for e.metaKey || e.ctrlKey, but these are always undefined because QJ.normalizeEvent() doesn't copy them from the original event.

Relevant links to the code:

#57 is probably the same issue, since formatCardNumber() uses restrictNumeric().

@jessepollak
Copy link
Owner

Thanks for opening this issue — I'd love to accept a PR on qj for this fix. If you can't do it, I can probably take a look this weekend.

@Changaco
Copy link
Author

@jessepollak I'm not going to work on a fix, sorry. I've decided to consolidate our own module instead of using yours.

@artemln
Copy link

artemln commented Nov 6, 2017

@jessepollak Please review PR #86

@bobrosoft
Copy link

@jessepollak hi there. Can you review that PR above? Experiencing same issue in our project when using Safari and trying to insert card number with Cmd+V

@melloware
Copy link
Collaborator

This was released in 2.4.0. If anyting from your PR is not in there please submit another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants