-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The visualReport should display images withour a blur #92
Comments
This is because small icons are saved with larger dimensions, it ends up looking stretched. I can enhance the capture element keyword to additionally take dimensions to save the image in. I will have to check if there's a way to automatically do this |
My bad. I had fixed the dimensions issue a while back. This issue is because the report html contains fixed width and height for each image in the table. Retaining the original image width and height might probably make the table look uneven. Will check it out. Meanwhile, if you are able to fix the css of the table cell, then you can raise a PR or send me the css changes. |
fixed width and height for each image in the table - is good!!! Also, I think that's the way it should be |
I assume that is the browser does blur for small image when it is displayed in bigger size then it is |
Yes because the width and height is fixed. Smaller images get stretched width and height wise |
Found some solution http://jsfiddle.net/namuol/VAXrL/1459/ |
Can you raise a PR with the changes? You need to make the changes here https://github.com/jz-jess/RobotEyes/blob/master/RobotEyes/report_generator.py#L315 . From line 315 - 335. I can test and merge it later. You can change the version 1.5.9 in setup.py |
Ah I see. We can't just add it for everything right. This needs to be added only if the image is small? Does it affect regular sized images as well? They should not be pixelated if they're not small |
Very good question!!! I will check and let known |
The style needs to be added to the img tags I believe. Not sure if adding to parent will work. You can add a css at the beginning within style tags img { width: 200 image-rendering: pixelated} something like this. |
|
Should I do somethink else that PR can be pushed? |
Nope. I need to test it as soon as I find sometime. Will merge after. You can install your branch into your systems meanwhile to use the fix. |
Does it possible to do that visualReport displays images without a blur?
A very small image looks horrible.
Example with the microphom from the google search input field:
![image](https://user-images.githubusercontent.com/48047242/115949683-65f2b800-a4df-11eb-8d3e-b1ceb90999e3.png)
The text was updated successfully, but these errors were encountered: