Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really Long Gifs. Keep them or skip them? #41

Open
zapplecat opened this issue Aug 24, 2016 · 5 comments
Open

Really Long Gifs. Keep them or skip them? #41

zapplecat opened this issue Aug 24, 2016 · 5 comments
Assignees

Comments

@zapplecat
Copy link
Collaborator

I described this in the chat room, but here we go again. I was making some mock responses for gameover and I did the following:

  1. I did a giphy.gif_random using 'doge' as the tag and got this
  2. Then I did another giphy.gif_random using store shibe as the tag and got this really long gif

What do we want to do with really long gifs? Should we check for the total frames and if there's too many, we'll skip them? Or do we not care?

@corez92
Copy link
Collaborator

corez92 commented Aug 24, 2016

is there like a giphy api to filter those long gifs out? But I agree, no long gifs

@zapplecat
Copy link
Collaborator Author

There's nothing in the api specifically, but we can filter by frames, probably

@zapplecat
Copy link
Collaborator Author

Maybe what we need to answer next is how long is "too long"?

@corez92
Copy link
Collaborator

corez92 commented Aug 25, 2016

use the gif that started this whole issue as a starting point

@corez92
Copy link
Collaborator

corez92 commented Aug 30, 2016

None of those links work, but so, we need a consensus on this, how long is too long?

edit [01-sep-2016]:
http://giphy.com/gifs/cool-kite-g2uitYUuKepZC (175)
http://giphy.com/gifs/cool-kShL0gh7XWoqk (61, I believe)

First one took like 15+ secs and other one 1/3 that time. I think 60 secs should be the upper limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants