Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add license text to the released tarball #60

Closed
valholl opened this issue Jul 30, 2015 · 1 comment
Closed

Please add license text to the released tarball #60

valholl opened this issue Jul 30, 2015 · 1 comment

Comments

@valholl
Copy link

valholl commented Jul 30, 2015

I've noticed that the tarball released on pypi is missing the LICENSE file, and while there are references to the MIT license, the only way to know the actual licensing terms is from the git repo.

Also, the code taken from IPython py3compat.py and encoding.py is marked as under the Modified BSD License, but the actual text of that license (plus copyright notice) is not repeated anywhere in the package (as requested by the license: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."). IANAL, but I believe that adding the text of the Modified BSD to LICENSE (including the copyright notice and specifying the parts to which it applies) should be enought.

Thanks in advance

@bebraw
Copy link
Contributor

bebraw commented Aug 1, 2015

Is it enough if I add LICENSE to MANIFEST.in? I don't mind accepting a PR for this. As far as I'm concerned the source is under MIT (a nominal thing really).

I barely develop Python these days so I'm pretty out of the loop with these things. 👍

@valholl valholl mentioned this issue Aug 9, 2015
@bebraw bebraw closed this as completed Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants