Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to new scope-based jest fn call parser to support @jest/globals #20

Merged
merged 5 commits into from
Aug 20, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Aug 20, 2022

Per the title, this pulls across the utils refactor from eslint-plugin-jest - I've added some tests to get full coverage rather than remove the unused code to make it easier to maintain + we might want those in future.

@G-Rath G-Rath merged commit 35ddfed into main Aug 20, 2022
@G-Rath G-Rath deleted the update-utils branch August 20, 2022 22:50
github-actions bot pushed a commit that referenced this pull request Aug 20, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-08-20)

### Features

* switch to new scope-based jest fn call parser to support `@jest/globals` ([#20](#20)) ([35ddfed](35ddfed))
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB
Copy link
Member

SimenB commented Aug 25, 2022

Should we create some sort of util module instead of copying over?

I know it's not quite rule of 3, but still 😀

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 25, 2022

Not yet - I want to look into eslint-plugin-jest-dom first and a few other things, but yeah I think it'll be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants