Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(valid-expect): support minArgs & maxArgs options #584

Merged
merged 1 commit into from
May 16, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 16, 2020

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm 👍 my only comment is that the message is less useful/precise for 99.9999% of people who use the "normal" expect, but I don't think it's a biggie

@G-Rath G-Rath force-pushed the support-min-and-max-arg-options-in-valid-expect branch from 12de4cd to 6116961 Compare May 16, 2020 09:25
@G-Rath G-Rath merged commit 9e0e2fa into master May 16, 2020
@G-Rath G-Rath deleted the support-min-and-max-arg-options-in-valid-expect branch May 16, 2020 09:58
github-actions bot pushed a commit that referenced this pull request May 16, 2020
# [23.13.0](v23.12.0...v23.13.0) (2020-05-16)

### Features

* **valid-expect:** support `minArgs` & `maxArgs` options ([#584](#584)) ([9e0e2fa](9e0e2fa))
@github-actions
Copy link

🎉 This PR is included in version 23.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants