Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lowercase-name): support ignoreTopLevelDescribe option #611

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 22, 2020

closes #247
closes #428

I think this should be the default in the next major, as it's a pretty common-case to have when testing classes.

@G-Rath G-Rath requested a review from SimenB June 22, 2020 06:18
@G-Rath G-Rath marked this pull request as draft June 22, 2020 06:21
@G-Rath G-Rath force-pushed the allow-uppercase-in-toplevel-describe branch from c362bbf to 0b75c4d Compare June 22, 2020 06:29
@G-Rath G-Rath marked this pull request as ready for review June 22, 2020 06:30
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but I don't think it should be the default. It seems inconsistent to me

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jun 23, 2020

Really? I agree except for with things like classes & components, which I feel is pretty common; but then again it's definitely not the most obvious or pressing option 🤷

@G-Rath G-Rath merged commit 36fdcc5 into master Jun 23, 2020
@G-Rath G-Rath deleted the allow-uppercase-in-toplevel-describe branch June 23, 2020 06:39
github-actions bot pushed a commit that referenced this pull request Jun 23, 2020
# [23.17.0](v23.16.0...v23.17.0) (2020-06-23)

### Features

* **lowercase-name:** support `ignoreTopLevelDescribe` option ([#611](#611)) ([36fdcc5](36fdcc5)), closes [#247](#247)
@github-actions
Copy link

🎉 This PR is included in version 23.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for lowercase-name rule to allow uppercase for top level describes
2 participants