Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-done-callback): fix regression with it.each #708

Merged
merged 3 commits into from
Nov 12, 2020
Merged

fix(no-done-callback): fix regression with it.each #708

merged 3 commits into from
Nov 12, 2020

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Nov 12, 2020

Closes #709

my recent PR #701 caused a false positive for no-done-callback when used with jest-each (sorry!)

it.each uses the first argument for options, and the second argument for the done callback.

This PR fixes the bug and adds test cases for it.each

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 12, 2020

I mucked up my commit, so it needs to be reworded 🤦‍♂️

@k-yle
Copy link
Contributor Author

k-yle commented Nov 12, 2020

@G-Rath shall I amend that commit? I don't see what's wrong with the commit message though

@G-Rath
Copy link
Collaborator

G-Rath commented Nov 12, 2020

@k-yle yes please - it's the capital letter, changing it to apply should fix it :)

@G-Rath G-Rath merged commit 2f032f8 into jest-community:master Nov 12, 2020
@k-yle k-yle deleted the fix-no-done-callback branch November 12, 2020 10:30
github-actions bot pushed a commit that referenced this pull request Nov 12, 2020
## [24.1.2](v24.1.1...v24.1.2) (2020-11-12)

### Bug Fixes

* **no-done-callback:** fix regression with it.each ([#708](#708)) ([2f032f8](2f032f8))
@github-actions
Copy link

🎉 This PR is included in version 24.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@voda
Copy link

voda commented Nov 12, 2020

@k-yle I found another false positive, reported in #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test.each no-done-callback false positive in version 24.1.1
4 participants