Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): add a test instead of throwing an error on getDocsUrl #96

Merged
merged 2 commits into from Mar 3, 2018
Merged

fix(util): add a test instead of throwing an error on getDocsUrl #96

merged 2 commits into from Mar 3, 2018

Conversation

ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Mar 2, 2018

getDocsUrl is a function that runs on the plugin's users machine, it returns a doc url, which is located on the remote.

The error should have verified that there is a corresponding doc file on the file system, which should indicate that the link won't be broken.

That logic can be done by a dedicated test, and by that, won't break the users in case this file does not exist.

note: In the test, we are using the rule key (name) from the main index.js, while the url is built from the __filename which should be the same as the key but i don't think that we verify that somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants