Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Rename and document pathToJest #44

Closed
seanpoulter opened this issue May 2, 2020 · 0 comments · Fixed by #45
Closed

Improvement: Rename and document pathToJest #44

seanpoulter opened this issue May 2, 2020 · 0 comments · Fixed by #45
Milestone
vscode-jest v4.0

Comments

@seanpoulter
Copy link
Member

I'm creating this issue to keep track of the suggestion from #41 and set a v4.0 milestone.

Acceptance criteria

  1. getSettings throws error with paths with spaces in Windows #41 (comment):
    We could just rename the ProjectWorkspace.pathToJest to ProjectWorkspace.jestCommandline

  2. Document the API change
  3. (Suggested) Continue to support pathToJest as a deprecated value.

CC @connectdotz @rossknudsen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vscode-jest v4.0
Development

Successfully merging a pull request may close this issue.

Renamed pathToJest to jestCommandLine in ProjectWorkspace rossknudsen/jest-editor-support
1 participant
@seanpoulter